Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary separator in version dropdown #2339

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Oct 17, 2023

Before:
Captura de pantalla 2023-10-16 a la(s) 18 45 29

After:
Captura de pantalla 2023-10-16 a la(s) 18 44 45

(we don't use separators after menu headers anymore since we added colored backgrounds in headers)

@berekuk berekuk requested a review from OAGr as a code owner October 17, 2023 00:45
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

⚠️ No Changeset found

Latest commit: c900343

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@berekuk berekuk temporarily deployed to Preview October 17, 2023 00:46 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 0:50am
quri-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 0:50am
squiggle-components ✅ Ready (Inspect) Visit Preview Oct 17, 2023 0:50am
squiggle-website ✅ Ready (Inspect) Visit Preview Oct 17, 2023 0:50am

@OAGr OAGr merged commit d0ddeda into main Oct 17, 2023
@OAGr OAGr deleted the remove-extra-separator branch October 17, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants