Imports in Hub

[berekuk]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 883a55f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quri-hub	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2023 9:59pm
quri-ui	✅ Ready (Inspect)	Visit Preview		Nov 1, 2023 9:59pm
squiggle-components	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2023 9:59pm
squiggle-website	✅ Ready (Inspect)	Visit Preview		Nov 1, 2023 9:59pm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1488cd) 71.72% compared to head (823223c) 71.76%.

❗ Current head 823223c differs from pull request most recent head 883a55f. Consider uploading reports for the commit 883a55f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2335      +/-   ##
==========================================
+ Coverage   71.72%   71.76%   +0.04%     
==========================================
  Files         113      113              
  Lines        5811     5820       +9     
  Branches     1117     1136      +19     
==========================================
+ Hits         4168     4177       +9     
  Misses       1636     1636              
  Partials        7        7              

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[OAGr]

(I realized this also applies when there's just a comment in the editor, so this isn't really a new issue)

Right now, an empty editor doesn't throw an error, but an editor with just an Import statement does. It feels like it would be nicer if the latter didn't.

[OAGr]

I like this name change. "Continues" is confusing to me.

[OAGr]

I think I'm done looking through this for now. Overall, seems pretty strong, looking forward to this!

I think the issue of imports often not working (maybe because of dashes) seems like something to fix before merging. The other comments are much more minor, feel free to merge without addressing them if you'd like.

[quinn-dougherty]

long time coming, this is what it's all about. you guys rule.