Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight multiline strings correctly #2302

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Highlight multiline strings correctly #2302

merged 2 commits into from
Sep 30, 2023

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Sep 29, 2023

Fixes #2246.

@berekuk berekuk requested a review from OAGr as a code owner September 29, 2023 22:25
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

🦋 Changeset detected

Latest commit: faf6786

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@quri/squiggle-components Patch
vscode-squiggle Patch
@quri/squiggle-lang Patch
@quri/prettier-plugin-squiggle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@berekuk berekuk temporarily deployed to Preview September 29, 2023 22:25 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 10:30pm
quri-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 10:30pm
squiggle-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 10:30pm
squiggle-website ✅ Ready (Inspect) Visit Preview Sep 29, 2023 10:30pm

@OAGr
Copy link
Contributor

OAGr commented Sep 30, 2023

The playground example still seems off to me, if I'm reading it right? The bottom of the string is colored - I assume it should be black/white.

https://squiggle-website-git-lezer-multiline-quantified-uncertainty.vercel.app/playground?v=0.8.5#code=eNqrVkpJTUsszSlxzk9JVbJSilGKyVNQUFZWVijOz00tycjMS4%2FJy80vSlXIT0MSiskDosxihcwShdSy1DwFDBX29kAlefkZCnn5QIYSiKNUCwAo1ibF

image

@berekuk
Copy link
Collaborator Author

berekuk commented Sep 30, 2023

@OAGr you need to switch to "Next" first.

Hmm, should the playground default to Next version?

@OAGr
Copy link
Contributor

OAGr commented Sep 30, 2023

Hmm, should the playground default to Next version?

Yep, that was it, thanks!

@berekuk berekuk merged commit c73af0d into main Sep 30, 2023
@berekuk berekuk deleted the lezer-multiline branch September 30, 2023 02:35
@github-actions github-actions bot mentioned this pull request Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Multiline string highlighting broken
2 participants