Merge pull request #3436 from quantified-uncertainty/ai-touchups

Improved AI sidebar, form fields when invalid
quantified-uncertainty · Nov 13, 2024 · f4b8611 · f4b8611
2 parents f48748b + ac326ab
commit f4b8611
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/packages/hub/src/app/ai/Sidebar.tsx b/packages/hub/src/app/ai/Sidebar.tsx
@@ -1,5 +1,6 @@
 "use client";
 
+import _ from "lodash";
 import {
   forwardRef,
   useEffect,
@@ -96,21 +97,23 @@ Outputs:
 
   const handleSubmit = form.handleSubmit(
     async ({ prompt, squiggleCode, model, numericSteps, styleGuideSteps }) => {
+      const numericStepsNumber = _.toNumber(numericSteps) || 0;
+      const styleGuideStepsNumber = _.toNumber(styleGuideSteps) || 0;
       const requestBody: AiRequestBody =
         mode === "create"
           ? {
               kind: "create",
               prompt,
               model: model as LlmId,
-              numericSteps,
-              styleGuideSteps,
+              numericSteps: numericStepsNumber,
+              styleGuideSteps: styleGuideStepsNumber,
             }
           : {
               kind: "edit",
               squiggleCode,
               model: model as LlmId,
-              numericSteps,
-              styleGuideSteps,
+              numericSteps: numericStepsNumber,
+              styleGuideSteps: styleGuideStepsNumber,
             };
 
       submitWorkflow(requestBody);
@@ -163,8 +166,9 @@ Outputs:
                   name="squiggleCode"
                   label="Squiggle Code"
                   placeholder="Enter your Squiggle code here"
-                  rows={12}
-                  minRows={12}
+                  rows={8}
+                  minRows={6}
+                  maxRows={20}
                 />
               </StyledTab.Panel>
             </StyledTab.Panels>

diff --git a/packages/ui/src/forms/fields/TextAreaFormField.tsx b/packages/ui/src/forms/fields/TextAreaFormField.tsx
@@ -17,9 +17,10 @@ export function TextAreaFormField<
   placeholder,
   rows,
   minRows,
+  maxRows,
   ...fieldProps
 }: CommonStringFieldProps<TValues, TName> &
-  Pick<StyledTextAreaProps, "placeholder" | "rows" | "minRows">) {
+  Pick<StyledTextAreaProps, "placeholder" | "rows" | "minRows" | "maxRows">) {
   return (
     <FormField {...fieldProps}>
       {(inputProps) => (
@@ -28,6 +29,7 @@ export function TextAreaFormField<
           placeholder={placeholder}
           rows={rows}
           minRows={minRows}
+          maxRows={maxRows}
         />
       )}
     </FormField>