Made docstring not null

quantified-uncertainty · Nov 17, 2023 · eac623b · eac623b
1 parent 84ca409
commit eac623b
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/packages/components/src/components/SquigglePlayground/index.tsx b/packages/components/src/components/SquigglePlayground/index.tsx
@@ -26,7 +26,7 @@ export type ModelExport = {
   variableName: string;
   variableType: string;
   title?: string;
-  docstring?: string;
+  docstring: string;
 };
 
 /*
@@ -124,7 +124,7 @@ export const SquigglePlayground: React.FC<SquigglePlaygroundProps> = (
         variableName: e[0],
         variableType: e[1].tag,
         title: e[1].title(),
-        docstring: e[1].context?.docstring() || undefined,
+        docstring: e[1].context?.docstring() || "",
       }));
       onExportsChange && onExportsChange(_exports);
     } else {

diff --git a/packages/hub/prisma/migrations/20231116222311_model_export_docstring/migration.sql b/packages/hub/prisma/migrations/20231116222311_model_export_docstring/migration.sql
diff --git a/packages/hub/prisma/migrations/20231117025418_model_export_docstring/migration.sql b/packages/hub/prisma/migrations/20231117025418_model_export_docstring/migration.sql
@@ -0,0 +1,2 @@
+-- AlterTable
+ALTER TABLE "ModelExport" ADD COLUMN     "docstring" TEXT NOT NULL DEFAULT '';
diff --git a/packages/hub/prisma/schema.prisma b/packages/hub/prisma/schema.prisma
@@ -235,7 +235,7 @@ model ModelExport {
   modelRevisionId String
   variableName    String
   title           String?
-  docstring       String?
+  docstring       String        @default("")
   variableType    String        @default("OTHER")
 
   @@unique([modelRevisionId, variableName], name: "uniqueKey")

diff --git a/packages/hub/schema.graphql b/packages/hub/schema.graphql
@@ -154,7 +154,7 @@ type ModelEdge {
 }
 
 type ModelExport implements Node {
-  docstring: String
+  docstring: String!
   id: ID!
   modelRevision: ModelRevision!
   title: String

diff --git a/packages/hub/src/graphql/mutations/updateSquiggleSnippetModel.ts b/packages/hub/src/graphql/mutations/updateSquiggleSnippetModel.ts
@@ -164,7 +164,7 @@ builder.mutationField("updateSquiggleSnippetModel", (t) =>
                   ({ variableName, variableType, docstring, title }) => ({
                     variableName,
                     variableType,
-                    docstring: docstring ?? null,
+                    docstring: docstring ?? undefined,
                     title: title ?? null,
                   })
                 ),

diff --git a/packages/hub/src/graphql/types/ModelRevision.ts b/packages/hub/src/graphql/types/ModelRevision.ts
@@ -22,7 +22,7 @@ builder.prismaNode("ModelExport", {
     modelRevision: t.relation("modelRevision"),
     variableName: t.exposeString("variableName"),
     variableType: t.exposeString("variableType"),
-    docstring: t.exposeString("docstring", { nullable: true }),
+    docstring: t.exposeString("docstring"),
     title: t.exposeString("title", { nullable: true }),
   }),
 });
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		-- AlterTable
		ALTER TABLE "ModelExport" ADD COLUMN "docstring" TEXT NOT NULL DEFAULT '';