Merge pull request #2920 from quantified-uncertainty/fix-isEqual-for-…

…lists Fixed isEqual for Squiggle Lists
quantified-uncertainty · Jan 4, 2024 · 3a1c31d · 3a1c31d · vercel · Jan 4, 2024
2 parents 9bcd0e3 + 7c4f9a3
commit 3a1c31d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/.changeset/new-ways-clap.md b/.changeset/new-ways-clap.md
@@ -0,0 +1,5 @@
+---
+"@quri/squiggle-lang": patch
+---
+
+Fix isEqual for Squiggle Lists
diff --git a/packages/squiggle-lang/__tests__/library/builtin_test.ts b/packages/squiggle-lang/__tests__/library/builtin_test.ts
@@ -22,6 +22,9 @@ describe("Operators", () => {
     testEvalToBe("0 == true", "false");
     testEvalToBe("0 == false", "false");
     testEvalToBe('"" == false', "false");
+    testEvalToBe("[1,2,3,5] == [1,2,3,5]", "true");
+    testEvalToBe("[1,2,3] == [1,2,3,5]", "false");
+    testEvalToBe("[1,2,3,8] == [1,2,3,5]", "false", true);
     testEvalToBe("normal(5,2) == normal(5,2)", "false");
     testEvalToBe("Sym.normal(5,2) == Sym.normal(5,2)", "true");
     testEvalToBe("Sym.uniform(10,12) == Sym.normal(5,2)", "false");

diff --git a/packages/squiggle-lang/src/value/index.ts b/packages/squiggle-lang/src/value/index.ts
@@ -112,7 +112,10 @@ class VArray extends BaseValue implements Indexable {
     }
 
     for (let i = 0; i < this.value.length; i++) {
-      isEqual(this.value[i], other.value[i]);
+      const _isEqual = isEqual(this.value[i], other.value[i]);
+      if (!_isEqual) {
+        return false;
+      }
     }
     return true;
   }