Responded to CRs

quantified-uncertainty · Jan 11, 2024 · 29ab0a5 · 29ab0a5
1 parent 0b4d932
commit 29ab0a5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/hub/src/relative-values/components/views/ListView/sidebar.tsx b/packages/hub/src/relative-values/components/views/ListView/sidebar.tsx
@@ -30,7 +30,7 @@ const TableRow: React.FC<TableRowProps> = ({ label, number }) => (
   </Fragment>
 );
 
-let buildurl = (
+let buildSquiggleCode = (
   model: ModelEvaluator,
   numeratorItem: Item,
   denominatorItem: Item,
@@ -113,7 +113,7 @@ export const ItemSideBar: FC<Props> = ({
     return <div>Result not found</div>;
   } else {
     let item = result.value;
-    const squggleCode = buildurl(
+    const squggleCode = buildSquiggleCode(
       model,
       numeratorItem,
       denominatorItem,

diff --git a/packages/hub/src/relative-values/components/views/PlotView/ForcePlot.tsx b/packages/hub/src/relative-values/components/views/PlotView/ForcePlot.tsx
@@ -173,7 +173,8 @@ export const ForcePlot: FC<{
     simulation.nodes(nodes);
 
     return simulation;
-  }, [model, nodes, forceFn]);
+    //Note: Don't add ``forceFn`` to the dependencies. ``forcefn`` is unstable, so this will cause unnecessary rerenders.
+  }, [model, nodes]);
 
   useEffect(() => {
     return () => {