Quatargo exercise - modify existing package - Zoltan #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=========================================
Coverage ? 18.18%
=========================================
Files ? 3
Lines ? 11
Branches ? 0
=========================================
Hits ? 2
Misses ? 9
Partials ? 0
Continue to review full report at Codecov.
|
mannau
requested changes
May 7, 2019
| @@ -1 +1,2 @@ | |||
| exportPattern("^[[:alpha:]]+") | |||
| importFrom("stats", "quantile") | |||
There was a problem hiding this comment.
Why haven't you used the package roxygen2 to generate the NAMESPACE file?
| @@ -1,4 +1,6 @@ | |||
| #' Meanimputation | |||
| #' @param x A vector. | |||
| @@ -0,0 +1,16 @@ | |||
| #' Transform_log | |||
| #' | |||
| #' Log transformation. | |||
There was a problem hiding this comment.
Description could be longer here.
| #' | ||
| #' Do some windsorization. | ||
| #' | ||
| #' Winsorizing or winsorization is the transformation of statistics by limiting |
There was a problem hiding this comment.
Nice description! Just missing how input parameter p influences the result
| q <- quantile(x, p) | ||
| x[x >= q] <- q | ||
| if(all(is.na(x))) {stop("argument should not be a vector containing only NA-s or NULL-s")} | ||
| q_up <- quantile(x, 0.5 + p / 2 ) |
There was a problem hiding this comment.
Try to consider the following situations:
- What happens if
xcontains someNAvalues? - What happens if
xis an empty/NULL vector?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.