Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octave_tools #182

Merged
merged 31 commits into from
Apr 2, 2024
Merged

octave_tools #182

merged 31 commits into from
Apr 2, 2024

Conversation

TheoLaudatQM
Copy link
Contributor

Functions to ease the update of the correction parameters when performing wide frequency sweeps (LO sweep in Python and IF in QUA)

Copy link

github-actions bot commented Dec 21, 2023

Unit Test Results

396 tests   393 ✔️  45s ⏱️
    1 suites      3 💤
    1 files        0

Results for commit 032d7e7.

♻️ This comment has been updated with latest results.

@TheoLaudatQM TheoLaudatQM force-pushed the get_correction_from_database branch from b12e6d6 to 2abd090 Compare December 21, 2023 14:35
@TheoLaudatQM TheoLaudatQM force-pushed the get_correction_from_database branch from 303519f to 22df725 Compare January 25, 2024 12:59
@TheoLaudatQM TheoLaudatQM force-pushed the get_correction_from_database branch from 22df725 to e8d7b86 Compare March 18, 2024 09:04
@TheoLaudatQM TheoLaudatQM requested review from deanpoulos, yomach and MichalGQM and removed request for KevinAVR, yonatanrqm, MichalGQM and yomach March 18, 2024 10:45
Copy link
Collaborator

@yomach yomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did zero testing, just went over readme + changelog + docstrings.
Attached are comments.
I suggest you also have people (CS?) play test it first

qualang_tools/octave_tools/README.md Outdated Show resolved Hide resolved
qualang_tools/octave_tools/README.md Outdated Show resolved Hide resolved
qualang_tools/octave_tools/README.md Outdated Show resolved Hide resolved
qualang_tools/octave_tools/README.md Outdated Show resolved Hide resolved
qualang_tools/octave_tools/README.md Outdated Show resolved Hide resolved
qualang_tools/octave_tools/README.md Outdated Show resolved Hide resolved
qualang_tools/octave_tools/README.md Show resolved Hide resolved
qualang_tools/octave_tools/README.md Outdated Show resolved Hide resolved
qualang_tools/octave_tools/octave_tools.py Outdated Show resolved Hide resolved
qualang_tools/octave_tools/octave_tools.py Show resolved Hide resolved
@TheoLaudatQM TheoLaudatQM requested a review from KevinAVR March 27, 2024 08:56
@TheoLaudatQM TheoLaudatQM force-pushed the get_correction_from_database branch 2 times, most recently from 7ce60e5 to 032d7e7 Compare April 2, 2024 14:27
@TheoLaudatQM TheoLaudatQM merged commit 6c9d945 into main Apr 2, 2024
2 checks passed
@TheoLaudatQM TheoLaudatQM deleted the get_correction_from_database branch April 2, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants