-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
octave_tools #182
Merged
Merged
octave_tools #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheoLaudatQM
requested review from
KevinAVR,
MichalGQM,
yomach and
yonatanrqm
December 21, 2023 14:31
TheoLaudatQM
force-pushed
the
get_correction_from_database
branch
from
December 21, 2023 14:35
b12e6d6
to
2abd090
Compare
TheoLaudatQM
force-pushed
the
get_correction_from_database
branch
from
January 25, 2024 12:59
303519f
to
22df725
Compare
TheoLaudatQM
force-pushed
the
get_correction_from_database
branch
from
March 18, 2024 09:04
22df725
to
e8d7b86
Compare
TheoLaudatQM
requested review from
deanpoulos,
yomach and
MichalGQM
and removed request for
KevinAVR,
yonatanrqm,
MichalGQM and
yomach
March 18, 2024 10:45
yomach
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did zero testing, just went over readme + changelog + docstrings.
Attached are comments.
I suggest you also have people (CS?) play test it first
yomach
approved these changes
Apr 2, 2024
TheoLaudatQM
force-pushed
the
get_correction_from_database
branch
2 times, most recently
from
April 2, 2024 14:27
7ce60e5
to
032d7e7
Compare
Add calibration function and get correction matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions to ease the update of the correction parameters when performing wide frequency sweeps (LO sweep in Python and IF in QUA)