Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Mode #180

Closed
wants to merge 148 commits into from
Closed

Video Mode #180

wants to merge 148 commits into from

Conversation

TheoLaudatQM
Copy link
Contributor

This module allows the user to update some pre-defined parameters of a QUA program while fetching data from the OPX for dynamic tuning (quantum dots, PID loop,...).

TheoLaudatQM and others added 30 commits November 28, 2023 10:15
returns the value of the parameters to the user
simplifies get parameters and allow the user to get the value of a parameter
The VideoMode thread is now closed automatically when the user closes the Python console in a "rough" manner, that is without manually terminating the Video mode additional thread
Create example section + black
The class will now raise an error if the user tries to access a QUA variable through the video mode which has not been declared within the QUA program through the call of the declare_variables() method
The video mode will now raise an error if the user tries to access a QUA variable which has not been priorly declared through the method declare_variables
qualang_tools/video_mode/README.md Outdated Show resolved Hide resolved
qualang_tools/video_mode/README.md Outdated Show resolved Hide resolved
qualang_tools/video_mode/README.md Show resolved Hide resolved
@yomach
Copy link
Collaborator

yomach commented Dec 20, 2023

So, I haven't gone through the actual code too much. I suggest we ask Rosmarin for a review, and also present it to a few other CS people to comment on small things such as readme and prompts.
But it looks very nice!

@TheoLaudatQM
Copy link
Contributor Author

Thanks, we already showed it to the CS team, but I kind of already tested it with Yiwen Chu students (PID example) and they liked it. The goal is to keep it confidential at the beginning so that we can test it with a few customers, the goal being to have it working for tuning up Quantum dots devices.
I am fine with Rosmarin reviewing it, but since Niv put it in the OKRs, it needs to be merged by tomorrow...

@yomach yomach requested a review from yonatanrqm December 21, 2023 10:16
@yomach
Copy link
Collaborator

yomach commented Dec 21, 2023

Thanks, we already showed it to the CS team, but I kind of already tested it with Yiwen Chu students (PID example) and they liked it. The goal is to keep it confidential at the beginning so that we can test it with a few customers, the goal being to have it working for tuning up Quantum dots devices. I am fine with Rosmarin reviewing it, but since Niv put it in the OKRs, it needs to be merged by tomorrow...

Then talk with Rosmarin and make sure he reviews it in time :)

qualang_tools/video_mode/videomode.py Outdated Show resolved Hide resolved
qualang_tools/video_mode/videomode.py Show resolved Hide resolved
qualang_tools/video_mode/videomode.py Outdated Show resolved Hide resolved
qualang_tools/video_mode/videomode.py Show resolved Hide resolved
qualang_tools/video_mode/videomode.py Outdated Show resolved Hide resolved
qualang_tools/video_mode/videomode.py Outdated Show resolved Hide resolved
qualang_tools/video_mode/videomode.py Outdated Show resolved Hide resolved
qualang_tools/video_mode/videomode.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@yomach yomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good.
Just need to finalize whether the user declares the type or not

arthurostrauss and others added 6 commits December 24, 2023 16:08
On top of the existing automatic type inference from the initial value given by the user, it is now possible to specify in the input dictionary which type shall be used to avoid any ambiguity on limiting cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants