Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Element call with default None arguments #174

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Fix Element call with default None arguments #174

merged 4 commits into from
Dec 5, 2023

Conversation

matpompili
Copy link
Contributor

When Element is called with some default arguments, it throws TypeErrors because the default None is not handled properly.

Example below throws an error before the changes.

cont = Controller("con1")
elm = Element("elm", digital_input_ports=[cont.digital_output(2)])

Remember to:

  • Update the CHANGELOG.md
  • Added tests for the feature or fix

@yomach yomach requested a review from TheoLaudatQM November 21, 2023 06:44
@yomach yomach merged commit a6c308a into qua-platform:main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomach yomach yomach approved these changes

@TheoLaudatQM TheoLaudatQM Awaiting requested review from TheoLaudatQM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matpompili @yomach