[3923][ADD] account_view_adj #361

liuhehe1995 · 2023-11-06T07:59:53Z

kanda999

Please run pre-commit before creating a PR. Also, please create a readme file.

kanda999 · 2023-11-06T08:20:30Z

account_invoice_view_adj/views/account_invoice_view_adj.xml

+            <field name="arch" type="xml">
+                <xpath expr="//tree/field[@name='state']" position="before">
+                    <!-- Adding the 'Responsible' field -->
+                    <field name="user_id" string="担当者"/>


Suggested change

<field name="user_id" string="担当者"/>

<field name="user_id" />

Add translations instead of using string to name columns

This field <field name="user_id" string="Responsible"/>
is inherited from "account.invoice.supplier.form" and cannot be changed.
If I change it to<field name="user_id" />and add a translation, the result will be "販売担当者".

rinaldifirdaus · 2023-11-08T06:54:28Z

account_invoice_view_adj/i18n/ja.po

I think you should add blank line at the end of this file.

rinaldifirdaus · 2023-11-08T06:56:32Z

account_invoice_view_adj/readme/DESCRIPTION.rst

Since this is a generic views adjustment module for the account invoice, you better make the description generic.
please check how its written on purchase_view_adj or stock_view_adj.

Thank you for pointing this out.
account_invoice_view_adj :This module makes adjustments to account invoice related views.
Refer to:
purchase_view_adj :This module makes adjustments to purchase related views.
stock_view_adj :This module makes adjustments to stock related views.

kanda999 · 2023-11-08T07:41:22Z

account_invoice_view_adj/views/account_invoice_view_adj.xml

+<?xml version="1.0"?>
+<odoo>
+    <data>
+        <!-- Inherit the list view to add the 'Responsible' field -->


What does this comment mean? If you read the code, you will know.

kanda999 · 2023-11-08T07:41:39Z

account_invoice_view_adj/views/account_invoice_view_adj.xml

+            <field name="inherit_id" ref="account.invoice_supplier_tree"/>
+            <field name="arch" type="xml">
+                <xpath expr="//tree/field[@name='state']" position="before">
+                    <!-- Adding the 'Responsible' field -->


This comment is the same.

Let it be known that adjustments are inherited from list view "account.invoice.supplier.tree",
"Responsible"field name come from form view "account.invoice.supplier.form".
Refer to 135
I thought about it and decided comments wasn't necessary,
it's already written in the code.

AungKoKoLin1997 · 2023-11-08T09:59:45Z

account_invoice_view_adj/__manifest__.py

+    "website": "https://www.quartile.co",
+    "version": "11.0.1.0.0",
+    "depends": ["base", "account"],
+    "data": ["views/account_invoice_view_adj.xml"],


Rename xml file with just model_name (eg. account_invoice_views.xml)

Thank you!
Change to "data": ["account_invoice_view_adj.xml"],

@liuhehe1995 You misunderstood Lin's comment and the change hasn't been tested.

I changed it to
["views/account_view_adj.xml"],

@liuhehe1995 You misunderstood still about Lin's comment. Please look at the names of the views in the other modules

AungKoKoLin1997 · 2023-11-08T10:00:15Z

account_invoice_view_adj/views/account_invoice_view_adj.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0"?>
+<odoo>
+    <data>


Suggested change

<data>

AungKoKoLin1997 · 2023-11-08T10:01:07Z

account_invoice_view_adj/views/account_invoice_view_adj.xml

+                </xpath>
+            </field>
+        </record>
+    </data>


Suggested change

</data>

Thank you!
I know the reason for removing .
starting with Odoo version 11.0, the tag is optional and can be omitted when writing module data files.

yostashiro

@liuhehe1995 Can you please rename the module to account_view_adj so that we won't have to create another module when there is another minor adjustment request on views from account module.

yostashiro

@liuhehe1995 Make sure to check 'Files changed' yourself before asking for a review.

yostashiro

Please regenerate readme file as well.

yostashiro · 2023-11-10T05:16:27Z

account_view_adj/__manifest__.py

+    "name": "Account Invoice View Adjust",
+    "category": "Invoicing",


Suggested change

"name": "Account Invoice View Adjust",

"category": "Invoicing",

"name": "Account View Adjust",

"category": "Accounting",

yostashiro · 2023-11-10T05:16:37Z

account_view_adj/__manifest__.py

+    "author": "Quartile Limited",
+    "website": "https://www.quartile.co",
+    "version": "11.0.1.0.0",
+    "depends": ["base", "account"],


Suggested change

"depends": ["base", "account"],

"depends": ["account"],

yostashiro · 2023-11-10T05:17:21Z

account_view_adj/i18n/ja.po

Regenerate the translation file.

yostashiro · 2023-11-10T05:17:45Z

account_view_adj/readme/DESCRIPTION.rst

@@ -0,0 +1 @@
+This module makes adjustments to account invoice related views.


Suggested change

This module makes adjustments to account invoice related views.

This module makes adjustments to account related views.

yostashiro · 2023-11-10T05:22:02Z

account_view_adj/views/account_invoice_views.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0"?>
+<odoo>
+        <record id="view_account_invoice_supplier_tree_inherit" model="ir.ui.view">


Is the adjustment only on supplier invoice tree (no need to adjust customer invoice side)?

No need.
On the Customer invoice side, the "販売担当者" is shown.

yostashiro · 2023-11-13T01:27:47Z

account_view_adj/views/account_invoice_views.xml

@@ -5,7 +5,7 @@
            <field name="model">account.invoice</field>
            <field name="inherit_id" ref="account.invoice_supplier_tree"/>
            <field name="arch" type="xml">
-                <xpath expr="//tree/field[@name='number']" position="after">
+                <xpath expr="//tree/field[@name='is_invoice_issuer']" position="before">


You can't do this as is_invoice_issuer comes from a custom module. Use a field from account module as the hook point.

I changed the position of "Responsible" to before the 'date_due'.

yostashiro · 2023-11-13T04:55:27Z

account_view_adj/README.rst

+Maintainers
+~~~~~~~~~~~
+
+This module is maintained by the OCA.


This module is NOT maintained by OCA. Please regenerate readme with --org-name=qrtl.

rinaldifirdaus

Functional test: Work as expected.

yostashiro

Please include the setup files in this PR.

yostashiro · 2023-11-13T08:18:33Z

account_view_adj/views/account_invoice_views.xml

+        <record id="view_account_invoice_supplier_tree_inherit" model="ir.ui.view">
+            <field name="name">account.invoice.supplier.tree.inherit</field>
+            <field name="model">account.invoice</field>
+            <field name="inherit_id" ref="account.invoice_supplier_tree"/>
+            <field name="arch" type="xml">
+                <xpath expr="//tree/field[@name='date_due']" position="before">
+                   <field name="user_id" string="Responsible"/>
+                </xpath>
+            </field>
+        </record>


Fix the indentation.

liuhehe1995 requested review from yostashiro, AungKoKoLin1997, kanda999 and rinaldifirdaus November 6, 2023 08:00

kanda999 requested changes Nov 6, 2023

View reviewed changes

rinaldifirdaus reviewed Nov 8, 2023

View reviewed changes

liuhehe1995 requested review from rinaldifirdaus and kanda999 November 8, 2023 07:35

kanda999 reviewed Nov 8, 2023

View reviewed changes

liuhehe1995 requested a review from kanda999 November 8, 2023 08:41

AungKoKoLin1997 requested changes Nov 8, 2023

View reviewed changes

yostashiro reviewed Nov 8, 2023

View reviewed changes

liuhehe1995 requested review from yostashiro and AungKoKoLin1997 November 10, 2023 03:38

yostashiro requested changes Nov 10, 2023

View reviewed changes

liuhehe1995 removed request for AungKoKoLin1997, kanda999 and rinaldifirdaus November 10, 2023 04:29

liuhehe1995 changed the title ~~[3923][ADD]account_invoice_view_adj~~ [3923][ADD]account_view_adj Nov 10, 2023

liuhehe1995 force-pushed the 3923-add-account_invoice_view_adj branch from 5017294 to e8149dd Compare November 10, 2023 05:02

liuhehe1995 requested review from yostashiro, kanda999, AungKoKoLin1997 and rinaldifirdaus November 10, 2023 05:06

yostashiro requested changes Nov 10, 2023

View reviewed changes

yostashiro changed the title ~~[3923][ADD]account_view_adj~~ [3923][ADD] account_view_adj Nov 10, 2023

yostashiro requested changes Nov 13, 2023

View reviewed changes

liuhehe1995 force-pushed the 3923-add-account_invoice_view_adj branch 2 times, most recently from 639e481 to 3924b68 Compare November 13, 2023 04:31

liuhehe1995 requested a review from yostashiro November 13, 2023 04:31

yostashiro reviewed Nov 13, 2023

View reviewed changes

liuhehe1995 requested a review from yostashiro November 13, 2023 07:48

rinaldifirdaus approved these changes Nov 13, 2023

View reviewed changes

yostashiro requested changes Nov 13, 2023

View reviewed changes

[3923][ADD]account_view_adj

e1878f5

liuhehe1995 force-pushed the 3923-add-account_invoice_view_adj branch from 2ec673b to e1878f5 Compare November 13, 2023 09:46

liuhehe1995 requested a review from yostashiro November 13, 2023 09:47

yostashiro approved these changes Nov 13, 2023

View reviewed changes

yostashiro merged commit 923e70d into 11.0 Nov 13, 2023
0 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3923][ADD] account_view_adj #361

[3923][ADD] account_view_adj #361

liuhehe1995 commented Nov 6, 2023

kanda999 left a comment

kanda999 Nov 6, 2023

liuhehe1995 Nov 8, 2023 •

edited

Loading

rinaldifirdaus Nov 8, 2023 •

edited

Loading

rinaldifirdaus Nov 8, 2023

liuhehe1995 Nov 8, 2023

kanda999 Nov 8, 2023

kanda999 Nov 8, 2023

liuhehe1995 Nov 8, 2023 •

edited

Loading

AungKoKoLin1997 Nov 8, 2023

liuhehe1995 Nov 8, 2023

yostashiro Nov 9, 2023

liuhehe1995 Nov 9, 2023

kanda999 Nov 9, 2023

AungKoKoLin1997 Nov 8, 2023

AungKoKoLin1997 Nov 8, 2023

liuhehe1995 Nov 8, 2023

yostashiro left a comment

yostashiro left a comment

yostashiro left a comment

yostashiro Nov 10, 2023

yostashiro Nov 10, 2023

yostashiro Nov 10, 2023

yostashiro Nov 10, 2023

yostashiro Nov 10, 2023

liuhehe1995 Nov 10, 2023 •

edited

Loading

yostashiro Nov 13, 2023

liuhehe1995 Nov 13, 2023

yostashiro Nov 13, 2023

rinaldifirdaus left a comment

yostashiro left a comment

yostashiro Nov 13, 2023

	<field name="user_id" string="担当者"/>
	<field name="user_id" />

		"name": "Account Invoice View Adjust",
		"category": "Invoicing",

		@@ -0,0 +1 @@
		This module makes adjustments to account invoice related views.

[3923][ADD] account_view_adj #361

[3923][ADD] account_view_adj #361

Conversation

liuhehe1995 commented Nov 6, 2023

kanda999 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuhehe1995 Nov 8, 2023 • edited Loading

Choose a reason for hiding this comment

rinaldifirdaus Nov 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuhehe1995 Nov 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yostashiro left a comment

Choose a reason for hiding this comment

yostashiro left a comment

Choose a reason for hiding this comment

yostashiro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuhehe1995 Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rinaldifirdaus left a comment

Choose a reason for hiding this comment

yostashiro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuhehe1995 Nov 8, 2023 •

edited

Loading

rinaldifirdaus Nov 8, 2023 •

edited

Loading

liuhehe1995 Nov 8, 2023 •

edited

Loading

liuhehe1995 Nov 10, 2023 •

edited

Loading