Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][3810][REF] sale_ext_sst #355

Merged
merged 2 commits into from
Oct 5, 2023
Merged

[11.0][3810][REF] sale_ext_sst #355

merged 2 commits into from
Oct 5, 2023

Conversation

AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Sep 29, 2023 •
edited
Loading

3810
This PR does:

  • Remove customization to requested_date
  • Separate a new module(sale_order_invoice_residual) with the function to compute invoice_residual.
  • Separate a new module(sale_order_partner_phone)
  • View adjustments are moved to the sale_view_adj_sst module.

kanda999
kanda999 reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request_date field already exists as a standard field.
So I don't think sale_ext_sst module is needed.
https://github.com/odoo/odoo/blob/01717dc71bae261dad8ad6515ff2b1e2be861295/addons/sale_order_dates/models/sale_order.py#L16

@AungKoKoLin1997
Copy link
Contributor Author

The request_date field already exists as a standard field. So I don't think sale_ext_sst module is needed. https://github.com/odoo/odoo/blob/01717dc71bae261dad8ad6515ff2b1e2be861295/addons/sale_order_dates/models/sale_order.py#L16

My mistake. I thought we want to remove all attributes from standard definition. Thank you.

kanda999
kanda999 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function and code review.

@kanda999 kanda999 merged commit 8e0718a into 11.0 Oct 5, 2023
0 of 2 checks passed
@AungKoKoLin1997 AungKoKoLin1997 deleted the 11.0-ref-sale_ext_sst branch October 12, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanda999 kanda999 kanda999 approved these changes

@yostashiro yostashiro yostashiro approved these changes

@rinaldifirdaus rinaldifirdaus Awaiting requested review from rinaldifirdaus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AungKoKoLin1997 @yostashiro @kanda999