[3625][ADD] product_group_product_manager #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yostashiro
requested changes
Aug 31, 2023
AungKoKoLin1997
force-pushed
the
11.0-add-account_invoice_validation_adj
branch
from
6212888
to
22bee9e
Compare
AungKoKoLin1997
changed the title
yostashiro
requested changes
Sep 4, 2023
Comment on lines
7
to
24
| <record id="rule_product_template_create_edit_delete" model="ir.rule"> | ||
| <field name="name">Product Template Create/Edit/Delete Rule</field> | ||
| <field name="model_id" ref="product.model_product_template"/> | ||
| <field name="groups" eval="[(4, ref('product_group_manage_product.group_manage_product'))]"/> | ||
| <field name="perm_read" eval="True"/> | ||
| <field name="perm_write" eval="True"/> | ||
| <field name="perm_create" eval="True"/> | ||
| <field name="perm_unlink" eval="True"/> | ||
| </record> | ||
| <record id="rule_product_create_edit_delete" model="ir.rule"> | ||
| <field name="name">Product Create/Edit/Delete Rule</field> | ||
| <field name="model_id" ref="product.model_product_product"/> | ||
| <field name="groups" eval="[(4, ref('product_group_manage_product.group_manage_product'))]"/> | ||
| <field name="perm_read" eval="True"/> | ||
| <field name="perm_write" eval="True"/> | ||
| <field name="perm_create" eval="True"/> | ||
| <field name="perm_unlink" eval="True"/> | ||
| </record> |
There was a problem hiding this comment.
Why do we need these record rules?
Comment on lines
2
to
3
| access_product_template,access_product_template,product.model_product_template,group_manage_product,1,1,1,0 | ||
| access_product_product,access_product_product,product.model_product_product,group_manage_product,1,1,1,0 |
There was a problem hiding this comment.
Any reason why perm_unlink should be false?
Suggested change
| access_product_template,access_product_template,product.model_product_template,group_manage_product,1,1,1,0 | |
| access_product_product,access_product_product,product.model_product_product,group_manage_product,1,1,1,0 | |
| access_product_template_manage_product,product.template.manage.product,product.model_product_template,group_manage_product,1,1,1,1 | |
| access_product_product_manage_product,product.product.manage.product,product.model_product_product,group_manage_product,1,1,1,1 |
| "author": "Quartile Limited", | ||
| "website": "https://www.quartile.co", | ||
| "category": "Product", | ||
| "license": "LGPL-3", |
There was a problem hiding this comment.
Suggested change
| "license": "LGPL-3", | |
| "license": "AGPL-3", |
yostashiro
reviewed
Sep 7, 2023
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <odoo> | ||
| <record id="group_manage_product" model="res.groups"> | ||
| <field name="name">Product Creation, Editing & Deletion</field> |
There was a problem hiding this comment.
Suggested change
| <field name="name">Product Creation, Editing & Deletion</field> | |
| <field name="name">Product Manager</field> |
Yes. |
AungKoKoLin1997
force-pushed
the
11.0-add-account_invoice_validation_adj
branch
from
3d42b95
to
1d7293b
Compare
yostashiro
approved these changes
Sep 7, 2023
| @@ -0,0 +1 @@ | |||
| This module adds a new group (group_manage_product) with permissions for creating, editing, and deleting products. | |||
There was a problem hiding this comment.
Suggested change
| This module adds a new group (group_manage_product) with permissions for creating, editing, and deleting products. | |
| This module adds a new group (group_product_manager) with permissions for creating, editing, and deleting products. |
yostashiro
changed the title
AungKoKoLin1997
force-pushed
the
11.0-add-account_invoice_validation_adj
branch
from
1d7293b
to
7dd3e9c
Compare
kanda999
requested changes
Oct 26, 2023
There was a problem hiding this comment.
@AungKoKoLin1997
I have found that if product manager don't have access to the product.price.history model, they get an error when they try to create a new product from sale.order.line or purchase.order.line.
So can product_manager please allow read write update delete of product.price.history?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3625