fix issues reported by PhpStan

qossmic · Oct 27, 2023 · 3a7450a · 3a7450a
1 parent e121444
commit 3a7450a
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 3 deletions.
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -48,6 +48,7 @@
             'import_functions' => false,
         ],
         'modernize_strpos' => false,
+        'no_superfluous_phpdoc_tags' => false,
         'ordered_imports' => true,
         'php_unit_no_expectation_annotation' => false,
         'void_return' => true,

diff --git a/src/Qossmic/DataMapper/PropertyMapperInterface.php b/src/Qossmic/DataMapper/PropertyMapperInterface.php
@@ -20,7 +20,16 @@
  */
 interface PropertyMapperInterface
 {
+    /**
+     * @param mixed $data
+     *
+     * @return mixed
+     */
     public function readPropertyValue($data);
 
+    /**
+     * @param mixed $data
+     * @param mixed $value
+     */
     public function writePropertyValue($data, $value): void;
 }
diff --git a/src/Qossmic/DependencyInjection/Compiler/RegisterExceptionHandlersPass.php b/src/Qossmic/DependencyInjection/Compiler/RegisterExceptionHandlersPass.php
@@ -39,6 +39,7 @@ public function process(ContainerBuilder $container): void
         $strategies = [];
 
         foreach ($container->findTaggedServiceIds('qossmic.rich_model_forms.exception_handler') as $id => $tag) {
+            /** @var class-string $class */
             $class = $container->getParameterBag()->resolveValue($container->getDefinition($id)->getClass());
             $exceptionHandlers[$id] = new TypedReference($id, $class);
 

diff --git a/src/Qossmic/ExceptionHandling/ExceptionHandlerInterface.php b/src/Qossmic/ExceptionHandling/ExceptionHandlerInterface.php
@@ -32,5 +32,8 @@
  */
 interface ExceptionHandlerInterface
 {
+    /**
+     * @param mixed $data
+     */
     public function getError(FormConfigInterface $formConfig, $data, \Throwable $e): ?Error;
 }
diff --git a/src/Qossmic/ExceptionHandling/ExceptionToErrorMapperTrait.php b/src/Qossmic/ExceptionHandling/ExceptionToErrorMapperTrait.php
@@ -26,6 +26,9 @@ trait ExceptionToErrorMapperTrait
 {
     private ExceptionHandlerRegistry $exceptionHandlerRegistry;
 
+    /**
+     * @param mixed $data
+     */
     private function mapExceptionToError(FormConfigInterface $formConfig, $data, \Throwable $e): ?Error
     {
         $exceptionHandlers = [];

diff --git a/src/Qossmic/ExceptionHandling/FormExceptionHandler.php b/src/Qossmic/ExceptionHandling/FormExceptionHandler.php
@@ -36,6 +36,9 @@ public function __construct(ExceptionHandlerRegistry $exceptionHandlerRegistry,
         $this->translationDomain = $translationDomain;
     }
 
+    /**
+     * @param mixed $data
+     */
     public function handleException(FormInterface $form, $data, \Throwable $e): void
     {
         if (null !== $error = $this->mapExceptionToError($form->getConfig(), $data, $e)) {

diff --git a/src/Qossmic/Instantiator/ObjectInstantiator.php b/src/Qossmic/Instantiator/ObjectInstantiator.php
@@ -25,7 +25,7 @@ abstract class ObjectInstantiator
     private $factory;
 
     /**
-     * @param class-string|\Closure|(callable&array) $factory
+     * @param mixed $factory
      */
     public function __construct($factory)
     {
@@ -34,7 +34,7 @@ public function __construct($factory)
 
     public function instantiateObject(): ?object
     {
-        if (\is_string($this->factory)) {
+        if (\is_string($this->factory) && class_exists($this->factory)) {
             $factoryMethod = (new \ReflectionClass($this->factory))->getConstructor();
 
             if (null === $factoryMethod) {
@@ -78,7 +78,13 @@ public function instantiateObject(): ?object
 
     abstract protected function isCompoundForm(): bool;
 
+    /**
+     * @return mixed
+     */
     abstract protected function getData();
 
+    /**
+     * @return mixed
+     */
     abstract protected function getArgumentData(string $argument);
 }
diff --git a/src/Qossmic/Instantiator/ViewDataInstantiator.php b/src/Qossmic/Instantiator/ViewDataInstantiator.php
@@ -33,7 +33,6 @@ class ViewDataInstantiator extends ObjectInstantiator
      */
     public function __construct(FormBuilderInterface $form, $viewData)
     {
-        /* @phpstan-ignore-next-line */
         parent::__construct($form->getFormConfig()->getOption('factory'));
 
         $this->form = $form;