-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Gradle build config to Kotlin #100
Open
aSemy
wants to merge
10
commits into
qoomon:master
Choose a base branch
from
aSemy:feat/gradle_kts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qoomon
reviewed
Oct 25, 2022
qoomon
approved these changes
Oct 25, 2022
qoomon
approved these changes
Oct 25, 2022
qoomon
approved these changes
Oct 25, 2022
qoomon
approved these changes
Dec 19, 2022
hey @qoomon, I see you've approved this PR, when did you want to merge it? Is there something more that I can do? |
hi @aSemy sorry I was on a long vacation. I'll probably merge it between the holidays. |
@qoomon No problem, take your time :) Let me know if I can help or adjust anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the build files to use the Kotlin DSL
Additionally
build.gradle
andsettings.gradle
files might be lost! It's difficult to get Git to recognise that a file has changed name and the content has also significantly changed. You might want to repeat the two commits a56e77e 7bc7f0c on the master branch if you want to keep the Git history