Added quantity for consumables. Added promo offers #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Qonversion.xcodeproj/project.pbxproj
suriksarkisyan
changed the title
SpertsyanKM
reviewed
Jul 19, 2024
Sources/Qonversion/Qonversion/Constants/QNAPIConstants/QNAPIConstants.m
Outdated
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Main/QNProductCenterManager/QNProductCenterManager.m
Outdated
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Main/QNProductCenterManager/QNProductCenterManager.m
Outdated
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Main/QNProductCenterManager/QNProductCenterManager.m
Outdated
Show resolved
Hide resolved
SpertsyanKM
reviewed
Aug 9, 2024
| @param completion Completion block that includes entitlements dictionary and error | ||
| */ | ||
| - (void)purchaseProduct:(QONProduct *)product quantity:(NSUInteger)quantity completion:(QONPurchaseCompletionHandler)completion; | ||
| - (void)purchaseProduct:(QONProduct *)product options:(QONPurchaseOptions *)options completion:(QONPurchaseCompletionHandler)completion; |
There was a problem hiding this comment.
Shouldn't we add options to the purchase method?
Comment on lines
+247
to
+248
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wmissing-declarations" |
There was a problem hiding this comment.
Yes, it should. Until we make this feature public in the next release.
| @@ -14,7 +14,7 @@ | |||
| NSString * const kInitEndpoint = @"v1/user/init"; | |||
| NSString * const kSendPushTokenEndpoint = @"v1/user/push-token"; | |||
| NSString * const kPurchaseEndpoint = @"v1/user/purchase"; | |||
| NSString * const kGetPromoOfferDetailsEndpoint = @"v3/purchase"; | |||
| NSString * const kGetPromoOfferDetailsEndpoint = @"update_promo_offer_endpoint_here"; | |||
Sources/Qonversion/Qonversion/Main/QNProductCenterManager/QNProductCenterManager.m
Outdated
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Main/QNProductCenterManager/QNProductCenterManager.m
Show resolved
Hide resolved
Sources/Qonversion/Qonversion/Main/QNProductCenterManager/QNProductCenterManager.m
Outdated
Show resolved
Hide resolved
SpertsyanKM
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.