Hierarchy #38
Merged
Hierarchy #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Classes only (1 litho, 2 litho, etc processes... to be determined) and created a cells.py module to store all cells already created
…e ignored when generate_api.py is called (ignoring __folders)
Closed
reed-foster
reviewed
Apr 19, 2024
reed-foster
reviewed
Apr 19, 2024
reed-foster
reviewed
Apr 19, 2024
reed-foster
reviewed
Apr 19, 2024
reed-foster
reviewed
Apr 19, 2024
reed-foster
reviewed
Apr 19, 2024
reed-foster
reviewed
Apr 19, 2024
reed-foster
reviewed
Apr 19, 2024
reed-foster
reviewed
Apr 19, 2024
reed-foster
reviewed
Apr 19, 2024
reed-foster
reviewed
Apr 19, 2024
reed-foster
requested changes
Apr 19, 2024
There was a problem hiding this comment.
Looks great. I had a couple comments that should get addressed:
- naming of nanowire.spot
- removal of docstrings in plot_images
- question about naming of __default_param
I had a few other more general comments, but I'll move those to separate issues, since they're not specifically relevant to this PR.
|
Okay I created separate issues and replied to all the comments I originally left referencing those issues so that way only a few things need to be addressed here before merging. |
reed-foster
reviewed
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition to answer issue #31
Broke the hierarchy in devices.
The same can be done later for other modules more easily because generate_api and plot_images are automatized (no dependence on modules names).
Broke geometries in geometries (hyp tap etc...) and tests (alignment, resolution etc...), and design in design (classes) and cells (pre-built cells).
Updated documentation accordingly (check qnngds documentation for user and for dev).
Created a __default_param.py file to store the default values in functions over the entire module.