Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# Support #1388

Merged
merged 55 commits into from
Jan 8, 2025
Merged

C# Support #1388

merged 55 commits into from
Jan 8, 2025

Conversation

noahd1
Copy link
Member

@noahd1 noahd1 commented Jan 2, 2025

No description provided.

@qltysh qltysh
Copy link
Contributor

qltysh bot commented Jan 2, 2025 •
edited
Loading

3 new issues

Tool Category Rule Count
qlty Duplication Found 33 lines of similar code in 3 locations (mass = 273) 3

qlty successfully analyzed this pull request in 3m.

qltysh[bot]
qltysh bot reviewed Jan 2, 2025
View reviewed changes
qlty-analysis/src/lang.rs Outdated Show resolved Hide resolved
qlty-analysis/src/lang.rs Outdated Show resolved Hide resolved
qlty-analysis/src/lang/c_sharp.rs Outdated Show resolved Hide resolved
qlty-analysis/src/lang/c_sharp.rs Outdated Show resolved Hide resolved
qlty-analysis/src/lang/c_sharp.rs Outdated Show resolved Hide resolved
qlty-analysis/src/lang/c_sharp.rs Outdated Show resolved Hide resolved
qltysh[bot]
qltysh bot reviewed Jan 2, 2025
View reviewed changes
qlty-analysis/src/lang/c_sharp.rs Outdated Show resolved Hide resolved
qlty-analysis/src/lang/c_sharp.rs Outdated Show resolved Hide resolved
qlty-analysis/src/lang/c_sharp.rs Outdated Show resolved Hide resolved
@qltysh qltysh
Copy link
Contributor

qltysh bot commented Jan 3, 2025 •
edited
Loading

The code coverage on the diff in this pull request is 96.2%

Drilldown
Path File Coverage Δ
qlty-types/src/lib.rs 0.1
qlty-check/src/tool/command_builder.rs 2.6
qlty-check/src/tool/ruby/sys/macos.rs 3.1
qlty-check/src/tool/download.rs 0.7
qlty-check/src/executor/driver.rs -0.9
qlty-check/src/tool/ruby/sys/linux.rs -1.6
qlty-analysis/src/lang/csharp.rs 96.5

@noahd1 noahd1 changed the title C-Sharp Support (WIP) C# Support (WIP) Jan 3, 2025
qltysh[bot]
qltysh bot reviewed Jan 3, 2025
View reviewed changes
qlty-analysis/src/lang/c_sharp.rs Outdated Show resolved Hide resolved
qlty-analysis/src/lang/c_sharp.rs Outdated Show resolved Hide resolved
brynary
brynary reviewed Jan 3, 2025
View reviewed changes
qlty-analysis/src/lang.rs Outdated Show resolved Hide resolved
qltysh[bot]
qltysh bot reviewed Jan 3, 2025
View reviewed changes
qlty-analysis/src/lang/csharp.rs
pub const OR: &'static str = "||";
}

impl Default for CSharp {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 15 lines of similar code in 8 locations (mass = 67) [qlty:similar-code]

qlty-analysis/src/lang/csharp.rs Show resolved Hide resolved
rossta
rossta reviewed Jan 6, 2025
View reviewed changes
qlty-cli/tests/lang/csharp/basic.in/FileComplexity.cs
if (foo % 17 == 0)
{
Console.WriteLine("Nested!");
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossta !!!!!! Keen eye on that one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra set of eyes, @rossta !

qltysh[bot]
qltysh bot reviewed Jan 8, 2025
View reviewed changes
qlty-analysis/src/lang/csharp.rs
}
}

fn field_identifiers(&self, source_file: &File, node: &Node) -> (String, String) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 18 lines of similar code in 2 locations (mass = 132) [qlty:similar-code]

@noahd1 noahd1 marked this pull request as ready for review January 8, 2025 04:07
brynary
brynary approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@brynary brynary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@noahd1 noahd1 changed the title C# Support (WIP) C# Support Jan 8, 2025
qltysh[bot]
qltysh bot reviewed Jan 8, 2025
View reviewed changes
qlty-analysis/src/lang/csharp.rs
pub field_query: tree_sitter::Query,
}

impl CSharp {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 33 lines of similar code in 3 locations (mass = 273) [qlty:similar-code]

@noahd1 noahd1 merged commit 31e59ba into main Jan 8, 2025
11 checks passed
@noahd1 noahd1 deleted the nd-c-sharp branch January 8, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

@rossta rossta rossta left review comments

@brynary brynary brynary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahd1 @brynary @rossta