Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Skip workspace folders where no diagramsRoot folder exist #590

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SinTh0r4s
Copy link

@SinTh0r4s SinTh0r4s commented Jun 19, 2024

I have a project where I use your extension to generate my diagrams. It is really convenient. Thanks for developing it <3

My project contains several workspace folders, but my documentation is only located in the one folder. This leads to a crash:
Error: ENOENT: no such file or directory, stat '<workspace_folder>\<diagramsRoot>'

It is the same issue referred to here: #414

This PR adds a simple check to only search for diagrams if the diagramsRoot exists in the workspace folder.

It is currently only possible to check the entire project for diagrams by leaving diagramsRoot empty, but my repo is large and it takes a minute to scan. I'd really love to have this small improvement as it would speed up my workflow.

Cheers,
Sin

@SinTh0r4s SinTh0r4s changed the title [Bugfix] Skip workspace folders where no diagrams exist [Bugfix] Skip workspace folders where no diagramsRoot folder exist Jun 19, 2024
@SinTh0r4s SinTh0r4s marked this pull request as ready for review June 20, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant