Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a _get_cvar_aggregation function #32

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add a _get_cvar_aggregation function #32

wants to merge 2 commits into from

Conversation

a-matsuo
Copy link
Collaborator

Summary

Add a _get_cvar_aggregation function and an aggregation arg to qaoa_sampler_cost_fun.

Details and comments

eggerdj
eggerdj reviewed Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@eggerdj eggerdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please add some tests. A how-to would also be good but could be done in a second PR.

qopt_best_practices/cost_function/cost_utils.py Show resolved Hide resolved
qopt_best_practices/cost_function/cost_utils.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggerdj eggerdj eggerdj left review comments

@ElePT ElePT Awaiting requested review from ElePT ElePT will be requested when the pull request is marked ready for review ElePT is a code owner

@Cryoris Cryoris Awaiting requested review from Cryoris Cryoris will be requested when the pull request is marked ready for review Cryoris is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-matsuo @eggerdj