Issue 344, Issue 436 and Issue 431 #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewvandeth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #344 Resolves #436 Resolves #431
Details and comments
Issue #344 is resolved by fixing the overflow of int types in the partition methods. This is corrected to int64_t in the compiled version. However this will only work for n-k<63 in both versions. A note has been added to let the user know if the algorithm is not suitable when n-k is too large.
This could be fixed by using gpm or similar for large integers.
Issue #436 is resolved by switching to attribute access.
Issue #431 is resolved by changing
+=to^=