Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PRs and deploy docs on push #401

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

arnaucasau
Copy link
Collaborator

@arnaucasau arnaucasau commented Oct 16, 2023

Summary

This PR updates the tests.yml file to run the tests only on pull requests. So far, the tests were running on both PRs and pushes to the main branch. Given that it is required that a PR is up-to-date with the main branch to be merged, there's no need to duplicate those tests. Running the same tests more than once is a waste of computing resources that are represented into actual resources in the real world, like trees being burned. This PR also updates the docs-deploy.yml to deploy the documentation on pushes to the main branch.

Copy link
Collaborator

@grace-harper grace-harper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grace-harper grace-harper merged commit a8aee06 into qiskit-community:main Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants