Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python version to 3.8-3.11 #397

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

arnaucasau
Copy link
Collaborator

Summary

Update of the python version to work with python 3.8 to 3.11.

@arnaucasau arnaucasau mentioned this pull request Oct 6, 2023
@arnaucasau arnaucasau marked this pull request as ready for review October 9, 2023 19:12
Copy link
Collaborator

@grace-harper grace-harper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grace-harper grace-harper self-requested a review October 13, 2023 14:12
Copy link
Collaborator

@grace-harper grace-harper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you update python versions for black the pyproject.toml? Currently, target-version = ['py36', 'py37', 'py38', 'py39'] includes python 3.6 and 3.7

  • Can you update python versions in the .github/workflows/pypi-release.yml? python-version: '3.7' still has it's own section.

  • Can you update python versions in .github/workflows/tests.yml python 3.7 is still in python-version: [3.7, 3.9]

  • [ ]

@arnaucasau
Copy link
Collaborator Author

Thank you Grace, updated the pyproject.toml to python 3.8-3.11. I think .github/workflows/pypi-release.yml and .github/workflows/tests.yml are already updated, but maybe I'm wrong.

@Eric-Arellano
Copy link
Contributor

The GitHub branch protection rules will need to be updated by you @grace-harper to stop looking for 3.7 and 3.9 when merging. Instead, it should look for 3.8 and 3.11, but that probably won't pop up in the list until this is merged.

@grace-harper
Copy link
Collaborator

The GitHub branch protection rules will need to be updated by you @grace-harper to stop looking for 3.7 and 3.9 when merging. Instead, it should look for 3.8 and 3.11, but that probably won't pop up in the list until this is merged.

Hey @Eric-Arellano Thanks. I went ahead and removed the need for 3.7. We want it to look for 3.8-3.11, right?

@Eric-Arellano
Copy link
Contributor

We want it to look for 3.8-3.11, right?

Only 3.8 and 3.11. While it's technically more correct to run CI for 3.9 and 3.10 too, it's an extremely high chance that your code will work with 3.9 and 3.10 if it already works for 3.8 and 3.11. It's not worth wasting the compute resources to also test 3.9 and 3.10, which takes up CI resources and has an environmental cost.

Copy link
Collaborator

@grace-harper grace-harper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grace-harper grace-harper merged commit 0517046 into qiskit-community:main Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants