-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python version to 3.8-3.11 #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Can you update python versions for black the
pyproject.toml
? Currently,target-version = ['py36', 'py37', 'py38', 'py39']
includes python 3.6 and 3.7 -
Can you update python versions in the
.github/workflows/pypi-release.yml
?python-version: '3.7'
still has it's own section. -
Can you update python versions in
.github/workflows/tests.yml
python 3.7 is still inpython-version: [3.7, 3.9]
-
[ ]
Thank you Grace, updated the |
The GitHub branch protection rules will need to be updated by you @grace-harper to stop looking for 3.7 and 3.9 when merging. Instead, it should look for 3.8 and 3.11, but that probably won't pop up in the list until this is merged. |
Hey @Eric-Arellano Thanks. I went ahead and removed the need for 3.7. We want it to look for 3.8-3.11, right? |
Only 3.8 and 3.11. While it's technically more correct to run CI for 3.9 and 3.10 too, it's an extremely high chance that your code will work with 3.9 and 3.10 if it already works for 3.8 and 3.11. It's not worth wasting the compute resources to also test 3.9 and 3.10, which takes up CI resources and has an environmental cost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Update of the python version to work with python 3.8 to 3.11.