Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #367 - Migration from QasmSimulator to qiskit_aer's AerSimulator #378

Conversation

robotAstray
Copy link
Contributor

Summary:

This PR addresses issue #367 by implementing changes across various files in the codebase. The changes involve the migration from qiskit.Aer to qiskit_aer, replacement of QasmSimulator with AerSimulator, and the introduction of PadDynamicalDecoupling. Additionally, the PR requires the use of ALAPScheduleAnalysis within the PassManager

Details and comments:

The following files have been modified as part of this PR:

  • src/qiskit_qec/analysis/faultenumerator.py
  • src/qiskit_qec/analysis/faultsampler.py
  • src/qiskit_qec/circuits/repetition_code.py
  • test/code_circuits/test_rep_codes.py
  • test/heavy_hex_codes/test_heavy_hex_decoder.py
  • test/matching/test_circuitmatcher.py
  • test/matching/test_repetitionmatcher.py

Key Changes:

  • Migration from qiskit.Aer to qiskit_aer,
  • Migration from from QasmSimulator to AerSimulator
  • Introduction of PadDynamicalDecoupling, which requires the use of ALAPScheduleAnalysis in PassManager.

@robotAstray robotAstray marked this pull request as ready for review August 8, 2023 23:23
@robotAstray
Copy link
Contributor Author

@grace-harper this PR is ready for review 👍

@robotAstray robotAstray changed the title Migration from QasmSimulator to qiskit_aer's AerSimulator Issue 367 - Migration from QasmSimulator to qiskit_aer's AerSimulator Aug 17, 2023
@robotAstray robotAstray changed the title Issue 367 - Migration from QasmSimulator to qiskit_aer's AerSimulator Issue #367 - Migration from QasmSimulator to qiskit_aer's AerSimulator Aug 17, 2023
@grace-harper grace-harper self-assigned this Aug 17, 2023
@robotAstray
Copy link
Contributor Author

Hello @grace-harper the errors are related to a bug I identified and described in issue #380. I do not think is related to the work I did on issue #367.

@grace-harper grace-harper self-requested a review September 19, 2023 16:42
* remove execute import from faultsampler.py

* remove execute imports from faultenumerator.py

* remove execute import from test_heavy_hex_decoder.py

* remove execute import from test_repetitionmatcher.py

* remove execute import from test_circuitmatcher.py
Copy link
Collaborator

@grace-harper grace-harper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grace-harper grace-harper merged commit df4cc1d into qiskit-community:main Sep 20, 2023
3 checks passed
@robotAstray robotAstray deleted the bugfix-migration-from-qasmsimulator branch September 20, 2023 19:20
grace-harper added a commit that referenced this pull request Oct 2, 2023
#378)

* Migration from QasmSimulator to qiskit_aer's AerSimulator

* eliminate execute from imports (#1)

* remove execute import from faultsampler.py

* remove execute imports from faultenumerator.py

* remove execute import from test_heavy_hex_decoder.py

* remove execute import from test_repetitionmatcher.py

* remove execute import from test_circuitmatcher.py

---------

Co-authored-by: grace-harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants