289 fib decoder

[ghost]

Summary

Addresses #289
Fibonacci Decoder

Details and comments

[ghost]

I think something might be wrong with our checks? This should be flagging pylint errors for lack of documentation, no?

[dsvandet]

Please make sure to include a strong description of what this method is doing and building.

Comments:

1. Missing documentation stating what the method is creating and a reference to the paper. i.e. Sec II of paper gives the appropriate definitions ... Also state that is this the particular case for L=2^k. Need to include what start_arr is. I might relabel this as start_array or start_vector or simply seed
2. Missing type hints
3. I might change dtype=int to dtype=np.int8
4. I might shorten the name to just gen_fib_code_word
5. This is only well defined for L=2^k so that should be checked for. It is not clear to me if the input should therefor be k instead of L then. Either way I would create a gen_fib_code_word and _gen_fib_code_word which is consistent with the framework style.

[dsvandet]

Is the code from Georgia and Ben or is this code that you developed? If code from Georgia and Ben please add to comments that code was originally developed by ... and include a reference to the paper.

Does this code "specialty" code, i.e. not really using the framework but just an inclusion, If so we should discuss how to include such code and an initial set. We have to make the same decisions for the machine learning decoder that we are moving in. Let's discuss.

[grace-harper]

Hey Drew,
The quantum code was developed by Ben and Georgia. The python code, I wrote based on their paper. I have the paper referenced in the README, but I can reference it elsewhere if need be.

[CLAassistant]

All committers have signed the CLA.