-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for mypy errors #1362
base: main
Are you sure you want to change the base?
Fix for mypy errors #1362
Conversation
It seems the In other words to use |
Pull Request Test Coverage Report for Build 8992324779Details
💛 - Coveralls |
@1ucian0 Since I did this pylint released a new version and you see in Actions here the nightly run has been failing for some time. While this could be merged, if I change the branch rules as this changed the jobs, the merge CI will fail as it will fail dues to pylint. I had thought to add the necessary pylint changes/fixes to this PR as well. Either way merging just what I did so far here is no longer, on its own, going to get CI operational again. |
sounds good! |
Summary
CI has been failing in nightlies with mypy for couple of weeks (since the new mypy release)
_validate_keys()
in the parent SparseLabelOp is defined as an abstract method! I removed these calls to super from the aboveDetails and comments
Stable branch would have the same issue but I did not label this for backporting as it includes a file (the majorana op) that is only present on main.