Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from qiskit-terra to qiskit #1229

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented Aug 31, 2023

Summary

Similar to qiskit-community/qiskit-machine-learning#680

Switches over to qiskit from qiskit-terra

  • requirements.txt updated
  • CI updated for install main dependencies
  • CONTRIBUTING.MD links etc updated. Plus I removed/simplified some bits which are no longer correct and may have led to confusion down the line.

Removed Neko integration/workflow

I also updated a couple of places that referred to Terra (I was searching for Terra) in all the files. I noted an occurence in adapt_vqe.rst but figured that will be changed to use qiskit_algorithms and sorted at that point.

Details and comments

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6041771499

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.856%

Totals Coverage Status
Change from base Build 6025008944: 0.0%
Covered Lines: 9810
Relevant Lines: 11166

💛 - Coveralls

Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few observations on the updates to CONTRIBUTING.md but otherwise this LGTM

CONTRIBUTING.md Outdated Show resolved Hide resolved
Test section. However please note Nature does not have any
[online tests](https://github.com/Qiskit/qiskit-terra/blob/main/CONTRIBUTING.md#online-tests)
[online tests](https://github.com/Qiskit/qiskit/blob/main/CONTRIBUTING.md#online-tests)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link does not exist any more. I am not even sure what this was originally referring to.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I did not check over these links - it is the same across the app repos as the contributing came from a common source. Its likely that since this was originally done, based on what Terra had, that these not longer exist. I believe this was around if the ibm provider was used - some tutorials had an optional section that you could enable. I do not recall what might have been in terra long ago. We could leave this for now - rather than make it different from the other app repos. I really do not know if/how this file might change - I just wanted to change any refs from Terra and removed some text that was not how things are done in order to remove any confusion that may have caused going forwards,

nor does it have
[test skip
options](https://github.com/Qiskit/qiskit-terra/blob/main/CONTRIBUTING.md#test-skip-options).
options](https://github.com/Qiskit/qiskit/blob/main/CONTRIBUTING.md#test-skip-options).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is said to not exist, but we actually do have slow tests now which can be triggered to run (or not) based on the state of an environment variable.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Steve Wood <[email protected]>
@mergify mergify bot merged commit b4e07f7 into qiskit-community:main Sep 4, 2023
15 checks passed
@woodsp-ibm woodsp-ibm deleted the use_qiskit branch September 4, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants