Map qiskit-terra versions to qiskit #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlaspuldaro
force-pushed
the
translate-package-versions
branch
from
05cbecd to
38f2cb0
Compare
|
@AngeloDanducci @1ucian0 This PR is ready for review. I updated the description with more details. Let me know if you have any comments. |
AngeloDanducci
approved these changes
Feb 12, 2024
1ucian0
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates package version from qiskit-terra to corresponding qiskit versions in:
Fixes #43
It also adds a version control doc (
benchmarked_versions.md), to keep track of benchmarked versions.IMPORTANT NOTES
1.This version translation resulted in a few gaps in minor versions we have not benchmarked (see this issue comment).
As a result of qiskit package being released more often than terra, the updated boxplot charts below now show missing minor versions (eg. 0.20.x to 0.23.x), :
It is not under the scope of this PR to add new results to fill the gaps between translated versions.This will be delivered on a follow up PR.
A new doc was created (
version_translation_benchmark_control.md) to control the qiskit minor versions:2.Results submitted to Metriq still have the associated qiskit-terra version. Another required step is to also update the qiskit versions there (no new results added). Since it's easier to update results through the API, it will be done lastly once we process missing results (as explained above).