Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing gui styles when installing #1007

Conversation

PositroniumJS
Copy link
Contributor

What are the issues this pull addresses (issue numbers / links)?

Fix #1006

Did you add tests to cover your changes (yes/no)?

No need

Did you update the documentation accordingly (yes/no)?

No need

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Add missing gui styles when installing with pip and fix some typos

Details and comments

Add missing gui styles when installing with pip and fix some typos

@CLAassistant
Copy link

CLAassistant commented Dec 28, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PositroniumJS PositroniumJS force-pushed the 1006-missing-gui-styles-when-installing branch 9 times, most recently from b91a4a0 to df7391d Compare December 29, 2024 23:59
@PositroniumJS PositroniumJS force-pushed the 1006-missing-gui-styles-when-installing branch from df7391d to 8f4752e Compare December 30, 2024 00:10
@zlatko-minev
Copy link
Collaborator

Have you checked this runs ok in practice? No errors

@PositroniumJS
Copy link
Contributor Author

Have you checked this runs ok in practice? No errors

Yes, in the installed package folder you get a styles directory containing for each style the file style.qss and the directory rc with all its photos

@zlatko-minev
Copy link
Collaborator

Wonderful job, thank you. This all looks pretty good to me

@zlatko-minev
Copy link
Collaborator

Can you take a look at #1002 , this will be a major update. I will try to merge these changes into that. I want to make sure that #1002 works for you. I hope to merge it in the next week or two.

@zlatko-minev zlatko-minev merged commit c1ed7c8 into qiskit-community:main Dec 31, 2024
6 of 9 checks passed
@PositroniumJS PositroniumJS deleted the 1006-missing-gui-styles-when-installing branch December 31, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing gui styles
3 participants