Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code in part 4 #706

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

FelixLehn
Copy link
Contributor

Summary

Trying to fix the issue from #685.

Details and comments

The issue is about the confusion of generating the test kernel matrix with only test featuresand not with the test and training features. When using that the kernel_pca needs to do fit_transform() for the testing which is not the common way, as the kernelPCA should not fit on the testing features.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6712638652

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.689%

Totals Coverage Status
Change from base Build 6712636714: 0.0%
Covered Lines: 1851
Relevant Lines: 1997

💛 - Coveralls

Copy link
Collaborator

@adekusar-drl adekusar-drl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this issue. Keep going :)

@adekusar-drl adekusar-drl merged commit 77227e3 into qiskit-community:main Nov 1, 2023
13 checks passed
oscar-wallis pushed a commit that referenced this pull request Feb 16, 2024
* Update Code Part 4

* Typo code update

---------

Co-authored-by: Anton Dekusar <62334182+adekusar-drl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants