-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cross-references to Terra and QML objects in docstrings #700
Merged
adekusar-drl
merged 17 commits into
qiskit-community:main
from
desmonty:update_docstring_references_to_terra
Oct 26, 2023
Merged
Use cross-references to Terra and QML objects in docstrings #700
adekusar-drl
merged 17 commits into
qiskit-community:main
from
desmonty:update_docstring_references_to_terra
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desmonty
requested review from
stefan-woerner,
woodsp-ibm and
adekusar-drl
as code owners
October 22, 2023 07:30
Pull Request Test Coverage Report for Build 6621015017
💛 - Coveralls |
woodsp-ibm
reviewed
Oct 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this. A few comments...
qiskit_machine_learning/utils/loss_functions/kernel_loss_functions.py
Outdated
Show resolved
Hide resolved
woodsp-ibm
reviewed
Oct 23, 2023
Co-authored-by: Steve Wood <[email protected]>
woodsp-ibm
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks again for making the contribution.
Thank you for the good job! |
oscar-wallis
pushed a commit
that referenced
this pull request
Feb 16, 2024
* quantum_kernel class redirection * Remove TypeError; Add ValueError on C * quantum_kernel class reference * References circuit.library classes * Reference quantum_kernel acceptable types * Fix reference to ZZFeatureMap * Improve reference to Statevector.data * Fix references * Fix quantum_kernel reference * Resolve unnecessary class info * Resolve unnecessary class info * Add condition to default; Harmonize * Resolve unnecessary class info * Fix strict attribute info * Fix wrong class info * Fix typo * Fix missing space Co-authored-by: Steve Wood <[email protected]> --------- Co-authored-by: Steve Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix Issue #474
Details and comments