Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AQGD optimizer groups objective function calls by default #116

Merged
merged 8 commits into from
Jan 25, 2024

Conversation

proeseler
Copy link
Contributor

@proeseler proeseler commented Dec 20, 2023

Summary

Fixes #50

It has been fixed that the AQGD optimizer groups objective function calls by default.

Details and comments

The number of requests is chunked in a similar way to the gradient_num_diff() method from the Optimizer class. The number of grouped evaluations can be controlled via the max_grouped_evals parameter now and a test has been added to check whether the new functionality works for a parallelizable and a non-parallelizable objective function.

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2023

CLA assistant check
All committers have signed the CLA.

@proeseler proeseler changed the title Fixed AQGD optimizer groups objective funtion calls by default Fixed AQGD optimizer groups objective function calls by default Dec 20, 2023
@woodsp-ibm
Copy link
Member

Note: CI is failing here for Python 3.12 - see #113

As to Algorithms Unit Tests / Monitor_Qiskit_Main (ubuntu-latest, 3.8) this is one a pair that test against the main branch in Qiskit, rather than stable release, so we can monitor for breaking changes as Qiskit develops. Neither of this monitor pair are required to pass for the PR (you can see they do not have the Required label. But it is something that will need investigating as to why this is happening as there should not be breaking changes like this - it just recently started it seems, the #113 has been going on a few days.

@coveralls
Copy link

coveralls commented Jan 11, 2024

Pull Request Test Coverage Report for Build 7583049769

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 90.66%

Totals Coverage Status
Change from base Build 7583003400: 0.08%
Covered Lines: 6484
Relevant Lines: 7152

💛 - Coveralls

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, thanks @proeseler for the contribution. I'll approve but wait for @woodsp-ibm's confirmation before merging.

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this and taking care of the comments. It all looks good to me - sorry for the delay in getting back and reviewing this.

@woodsp-ibm woodsp-ibm merged commit 8b0eb7e into qiskit-community:main Jan 25, 2024
18 checks passed
woodsp-ibm added a commit to woodsp-ibm/qiskit-algorithms that referenced this pull request Jan 25, 2024
ElePT pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[from qiskit] AQGD optimizer groups objective funtion calls by default
6 participants