-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed AQGD optimizer groups objective function calls by default #116
Conversation
releasenotes/notes/fix_aqgd_max_grouped_evals-fbe108c005a9b7ac.yaml
Outdated
Show resolved
Hide resolved
Note: CI is failing here for Python 3.12 - see #113 As to |
Pull Request Test Coverage Report for Build 7583049769
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, thanks @proeseler for the contribution. I'll approve but wait for @woodsp-ibm's confirmation before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this and taking care of the comments. It all looks good to me - sorry for the delay in getting back and reviewing this.
Summary
Fixes #50
It has been fixed that the AQGD optimizer groups objective function calls by default.
Details and comments
The number of requests is chunked in a similar way to the gradient_num_diff() method from the Optimizer class. The number of grouped evaluations can be controlled via the max_grouped_evals parameter now and a test has been added to check whether the new functionality works for a parallelizable and a non-parallelizable objective function.