-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress qiskit algorithm globals deprecation messages #110
Conversation
Pull Request Test Coverage Report for Build 7088705026
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to directly remove the import from qiskit instead of suppressing the warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry I meant the previous review as a comment, not an approval)
The approval was unintended as per above comment
I had delegated to the qiskit.utils algorithm_globals as a migration path if all that was done was to change the import from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I guess that I am getting a bit impatient with deprecations and removals hahaha
Summary
The algorithm_globals function here in Qiskit Algorithms delegates its behavior to the equivalent logic in Qiskit as part of the migration support from algorithms in Qiskit that were migrated here. Since that time the function in Qiskit has been deprecated and deprecation messages added to alert the user to the migration. When this logic here was initially done those deprecation messages were not present, but since that time the way the logic is here causes users to see these deprecation messages which they should not. These messages also flooded the combined deprecation output from CI here. This PR suppresses these around the points of usage here so the messages are no longer raised.
Details and comments