Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: consistent da_barplot color scheme #138

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

SergioAlias
Copy link
Contributor

Closes #137 (I hope so!)

Now a color scale in da_barplot is specified, mapping "enriched" to #4c78a8 and "depleted" to #f58518 (these are the colors used in the default Vega Color Scheme for Nominal fields, #tableau10).

@gregcaporaso
Copy link
Member

I confirmed that this works. Using this PR branch, here's the barplot generated on the Moving Pictures data:

Screenshot 2024-12-17 at 11 07 40 AM

When adding a filter, such that only depleted features remain, the color of those features stays consistent with the above plot:

qiime composition da-barplot \
  --i-data l6-ancombc-subject.qza \
  --p-significance-threshold 0.001 \
  --o-visualization l6-da-barplot-subject.qzv \
  --p-effect-size-threshold 4.3

Screenshot 2024-12-17 at 11 08 58 AM

Thanks for the PR @SergioAlias!

@gregcaporaso gregcaporaso merged commit c26af33 into qiime2:dev Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

IMP: da-barplot should use consistant colors for enriched/depleted
2 participants