Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qcow2 support #225

Closed
wants to merge 916 commits into from
Closed

Add qcow2 support #225

wants to merge 916 commits into from

Conversation

NateChoe1
Copy link
Contributor

This PR adds qcow2 disk image support while maintaining backwards compatibility. qemu-img does have support for raw image files, but I chose not to use that so the ALLOCATE flag would keep working. A lot of code could be removed by converting everything to use qemu-img, though.

@kroese
Copy link
Collaborator

kroese commented Dec 8, 2023

Thank you very much!! But two days ago I did a force push to the main branch, causing all existing forks to become invalid. I did not expect anyone was working on something, but I see your fork is from before that date.

Is it possible that you create a fresh fork and copy the three files you modified to that one? Because I cannot merge this one without breaking the master.

Thanks in advance!

@kroese
Copy link
Collaborator

kroese commented Dec 8, 2023

Also when switching the DISK_FMT flag on an existing install, it will not cleanup the old data.img but just creates a new data.qcow.

Would be really that when a data file is detected with the opposite extension to DISK_FMT, it would run qemu-img convert to convert from raw to qcow (and vice versa) instead of abandoning the existing disk and creating a new one. So that you can switch the flag without loosing any data.

I will see if I have the time to add that function after the pullrequest gets merged.

@NateChoe1 NateChoe1 closed this by deleting the head repository Dec 8, 2023
@NateChoe1 NateChoe1 mentioned this pull request Dec 8, 2023
@NateChoe1
Copy link
Contributor Author

Moved to #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants