-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support table referencing with columns #2063
base: master
Are you sure you want to change the base?
Conversation
- was performing the parsing of refs incorrectly in the wrong place
I have missed the case where a table is in a different sheet. Will cover it. It is a bit trickier when initially reading the excel file. Hence I'll finish what's left in the beginning of the next week. Hence the PR is currently in a draft phase. |
Hi @xuri, I think that it is ready for a review. Implementing the cross sheet table reference was tricky. TLDR I had to read a handful of metadata files until I could create the mapping:
The parsed files are metadata files, that should be small. Thus I think/hope that reading them shouldn't harm the performance of the library when calling I think that the PR is now ready for a review. Just one additional question. I tested table referencing of files opened with Any advices here? I'd like to bring a more complete unit test coverage. |
Thanks for your PR. I have been busy recently, will review for this as soon as possible. |
Hi, I'd like to make one more note. This PR targets only the most basic syntax. That is There are other more (sophisticated) syntaxes for table referencing. Examples include (see ms docs):
I haven't covered them because otherwise this PR would become too big. I propose to implement them in follow up PRs. The whole point of this PR is to set up the main foundations for table referencing. Once having the foundations adding additional syntaxes should be easy. |
Add support for table referencing (aka structured references)
Description
After experimenting I noticed that table references aren't supported.
Docs used for reference during implementation:
Related Issue
#2062
Motivation and Context
It allows table referencing when calculating cell formulas.
How Has This Been Tested
I tested it with unit tests. TODO (will test with actual files)
Types of changes
Checklist