Add format options relay nick changes fix #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2021
llmII
force-pushed
the
add-format-options-relay-nick-changes-fix
branch
from
7b9f709
to
1b18b6f
Compare
Allows for the user to define how messages are formatted back and forth between Discord and IRC.
llmII
force-pushed
the
add-format-options-relay-nick-changes-fix
branch
from
1b18b6f
to
963f39e
Compare
Allows for the user to define how messages are formatted back and forth between Discord and IRC.
This change lets us have our cake and eat it too. If the configuration for a format is `" "` then it will just not send that message type. Previously this worked but it would send an empty message which Discord just really doesn't like!
Merge branch 'formatting-options-feature' into add-format-options-relay-nick-changes-fix
Allow for an empty format of `" "` to basically drop nick change.
No, we shouldn't warn. Co-authored-by: Qais Patankar <[email protected]>
When it is first load, if an invalid key is present in `discord_format` we inform the user of a fatal error and exit. If it's on reload we don't apply the new format and inform the user such was not done and that there is an error with an invalid key being present in the `discord_format` setting.
When it is first load, if an invalid key is present in `discord_format` we inform the user of a fatal error and exit. If it's on reload we don't apply the new format and inform the user such was not done and that there is an error with an invalid key being present in the `discord_format` setting.
…ay-nick-changes-fix
|
Merged into #76. |
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #72 and #76.
Integrates support for PM's with the formatting options so that way they can have a way of being formatted as well.
Figure that all single-sourced messages (JOIN/PART/QUIT (PM via #75 and formatting for PM via #78) relayed towards Discord should have a way to format it.
Still pending figuring out best way to document this in
README.md.