Skip to content

Commit

Permalink
ngr: Fix Gradle test runner by removing invocation of install target
Browse files Browse the repository at this point in the history
The Gradle test runner failed to invoke `./gradlew install`, because
such a target did not exist.
  • Loading branch information
amotl committed Nov 23, 2023
1 parent c30bcc1 commit 9bb3d09
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
- Add a few testing helper utilities to `pueblo.testing`
- Fix dependencies for `test` extra by downgrading to `nbdime<4`
- Dependencies (extras): Remove "ngr", add "notebook", link "test" to "testing"
- ngr: Gradle test runner failed to invoke `./gradlew install` because such a
target did not exist.

## 2023-11-06 v0.0.3
- ngr: Fix `contextlib.chdir` only available on Python 3.11 and newer
Expand Down
1 change: 0 additions & 1 deletion pueblo/ngr/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ def install(self) -> None:
elif self.has_gradle_files:
if shutil.which("gradle"):
run_command("gradle wrapper")
run_command("./gradlew install")
else:
raise NotImplementedError("Unable to invoke target: install")

Expand Down

0 comments on commit 9bb3d09

Please sign in to comment.