Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch functional tensors needs sync'ing before transferring to CPU. #8483

Closed
wants to merge 1 commit into from
Closed

Torch functional tensors needs sync'ing before transferring to CPU. #8483

wants to merge 1 commit into from

Conversation

mcuiaws
Copy link
Contributor

@mcuiaws mcuiaws commented Dec 11, 2024

This patch fixes #8482.

jeffhataws
jeffhataws reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@jeffhataws jeffhataws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcuiaws will you add a test based on the testcase in #8482 ?

@mcuiaws mcuiaws mentioned this pull request Dec 12, 2024
Closed
@mcuiaws
Copy link
Contributor Author

mcuiaws commented Dec 12, 2024

Superseded by #8489

@mcuiaws mcuiaws closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffhataws jeffhataws jeffhataws approved these changes

@will-cromar will-cromar Awaiting requested review from will-cromar

@tengyifei tengyifei Awaiting requested review from tengyifei

@ManfeiBai ManfeiBai Awaiting requested review from ManfeiBai

Assignees
No one assigned
Labels
tpuci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xm.save() needs to synchronize functionalized tensors before calling _xla_get_cpu_tensors()
3 participants
@mcuiaws @jeffhataws @tengyifei