Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8475: add libtpu-wheels registry when building docker #8476

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

tengyifei
Copy link
Collaborator

@tengyifei tengyifei commented Dec 10, 2024

When building docker images, we install torch_xla[tpu] on there. If the old registry is used, then pip will only find an old version of libtpu and will then resolve to an older version torch_xla (2.5.1). I went over the repo and made sure every libtpu-releases registry is followed by libtpu-wheels.

Fixes #8475

@tengyifei tengyifei marked this pull request as ready for review December 10, 2024 00:09
When building docker images, we install `torch_xla[tpu]` on there.
If the old registry is used, then pip will only find an old version of
libtpu and will then resolve to an older version torch_xla (2.5.1). I
went over the repo and made sure every `libtpu-releases` registry is
followed by `libtpu-wheels`.

Fixes #8475.
@tengyifei tengyifei enabled auto-merge (squash) December 10, 2024 00:11
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@tengyifei tengyifei merged commit 47f737a into master Dec 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly ptxla docker incorrectly contains torch_xla 2.5.1
2 participants