Compute and hash buffer_donor_indices for step marker #8467
+89
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuiaws
changed the title
jeffhataws
requested review from
jonb377,
tengyifei,
will-cromar and
ManfeiBai
jeffhataws
reviewed
Dec 11, 2024
mcuiaws
force-pushed
the
fix_8464
branch
3 times, most recently
from
d195e04 to
ff003b8
Compare
jeffhataws
approved these changes
Dec 12, 2024
Refactor SetBufferDonors() so that the logic for computing donor indices in a separate function GetBufferDonors(). SyncTensorsGraphInternal() now calls GetBufferDonors(), and those indices are hashed first, and the passed into Compile(). This fixes pytorch#8464.
tengyifei
approved these changes
Dec 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor SetBufferDonors() so that the logic for computing donor
indices in a separate function GetBufferDonors().
SyncTensorsGraphInternal() now calls GetBufferDonors(), and
those indices are hashed first, and the passed into Compile().
This fixes #8464.