Update libtpu pin to 2024/12/05 / 0.0.5 stable #8461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengyifei
force-pushed
the
test
branch
3 times, most recently
from
4fc0e0f to
cd83871
Compare
lsy323
approved these changes
Dec 6, 2024
| @@ -64,10 +64,11 @@ | |||
|
|
|||
| base_dir = os.path.dirname(os.path.abspath(__file__)) | |||
|
|
|||
| _date = '20241122' | |||
There was a problem hiding this comment.
nits: Maybe adding a flag for using the stable version, and add the .dev{_date} conditionally. This might make future pin update using nightly easier.
There was a problem hiding this comment.
oops, github auto-merge got too happy. i'll upload a fixup PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stable libtpu is qualified with more tests compared to nightly tpu. In particular, it has also been qualified with all JAX unit tests, which is beneficial since we depend on JAX.
This PR switches to stable libtpu at HEAD. Later I'll cut a 2.6 branch and that will also get the stable libtpu.
Depending on a stable libtpu means we don't need as much churn of updating the pin. If we later find a urgent need to adopt a specific libtpu CL, we could still switch back to a nightly at HEAD without issues.