Stricter testing of sharding annotations after scan #8456
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengyifei
force-pushed
the
yifeit/scan-spmd-2
branch
from
2dcdd07 to
78df1d2
Compare
vanbasten23
approved these changes
Dec 5, 2024
rpsilva-aws
approved these changes
Dec 5, 2024
rpsilva-aws
reviewed
Dec 5, 2024
For `init` and `final_carry`, the sharding spec should look like `devices=[4]0,1,2,3`. For `xs` and `ys`, the sharding spec should look like `devices=[1,4]0,1,2,3`.
tengyifei
force-pushed
the
yifeit/scan-spmd-2
branch
from
78df1d2 to
2ee45ad
Compare
rpsilva-aws
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to test that the output of a
torch_xla.experimental.scanoperation are sharded correctly if their inputs are sharded. In other words, the XLA compiler should be able to propagate the sharding annotation.For
initandfinal_carry, the sharding spec should look likedevices=[4]0,1,2,3.For
xsandys, the sharding spec should look likedevices=[1,4]0,1,2,3.