[scan] Add a test under SPMD #8419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengyifei
force-pushed
the
yifeit/scan-spmd
branch
2 times, most recently
from
b3f1ff5 to
c9a5907
Compare
|
@yaochengji FYI |
|
I will take a look today. |
JackCaoG
reviewed
Nov 27, 2024
JackCaoG
reviewed
Nov 27, 2024
JackCaoG
reviewed
Nov 27, 2024
JackCaoG
approved these changes
Nov 27, 2024
Verifies that the GSPMD sharding annotation propagation pass can propagate through a While op and through the Body computation just fine.
tengyifei
force-pushed
the
yifeit/scan-spmd
branch
from
c9a5907 to
ccd98fe
Compare
rpsilva-aws
pushed a commit
to rpsilva-aws/xla
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies that the GSPMD sharding annotation propagation pass can propagate through a While op and through the Body computation just fine.