Migrate from capture_pre_autograd_graph to export_for_training #8398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capture_pre_autograd_graph API is deprecated and will be deleted.
yushangdi
added a commit
to yushangdi/pytorch
that referenced
this pull request
Dec 13, 2024
Summary: Delete the following API: - capture_pre_autograd_graph() - capture_pre_autograd_graph_using_training_ir() - gm_using_training_ir() There's no more call sites to `capture_pre_autograd_graph`. Except 1) two test cases in coreml, PR to remove: apple/coremltools#2400 2) XLA: one test case in pytorch/xla, PR to remove: pytorch/xla#8398 3) a few call sites guarded by version guard (< 2.5.0) Test Plan: CI Reviewed By: tugsbayasgalan Differential Revision: D64056353
yushangdi
added a commit
to yushangdi/pytorch
that referenced
this pull request
Dec 13, 2024
Summary: as title There's no more call sites to `capture_pre_autograd_graph`. Except 1) two test cases in coreml, PR to remove: apple/coremltools#2400 2) XLA: one test case in pytorch/xla, PR to remove: pytorch/xla#8398 3) a few call sites guarded by version guard (< 2.5.0) Test Plan: CI Differential Revision: D64056353
yushangdi
added a commit
to yushangdi/pytorch
that referenced
this pull request
Dec 16, 2024
Summary: Delete the following API: - capture_pre_autograd_graph() - capture_pre_autograd_graph_using_training_ir() - gm_using_training_ir() There's no more call sites to `capture_pre_autograd_graph`. Except 1) two test cases in coreml, PR to remove: apple/coremltools#2400 2) XLA: one test case in pytorch/xla, PR to remove: pytorch/xla#8398 3) a few call sites guarded by version guard (< 2.5.0) Test Plan: CI Reviewed By: tugsbayasgalan Differential Revision: D64056353
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 16, 2024
Summary: Delete the following API: - capture_pre_autograd_graph() - capture_pre_autograd_graph_using_training_ir() - gm_using_training_ir() There's no more call sites to `capture_pre_autograd_graph`. Except 1) two test cases in coreml, PR to remove: apple/coremltools#2400 2) XLA: one test case in pytorch/xla, PR to remove: pytorch/xla#8398 3) a few call sites guarded by version guard (< 2.5.0) Test Plan: CI Reviewed By: tugsbayasgalan Differential Revision: D64056353 Pull Request resolved: #143224 Approved by: https://github.com/tugsbayasgalan
huydhn
approved these changes
Dec 17, 2024
|
Ping for review as this is blocking a change on PyTorch side at pytorch/pytorch#143224 (comment) |
|
cc @lsy323 to help look review this PR from the TorchXLA side. |
lsy323
approved these changes
Dec 17, 2024
yushangdi
added a commit
to yushangdi/pytorch
that referenced
this pull request
Dec 17, 2024
Summary: Delete the following API: - capture_pre_autograd_graph() - capture_pre_autograd_graph_using_training_ir() - gm_using_training_ir() There's no more call sites to `capture_pre_autograd_graph`. Update XLA pin to include pytorch/xla#8398 Except 1) two test cases in coreml, PR to remove: apple/coremltools#2400 2) a few call sites guarded by version guard (< 2.5.0) Test Plan: CI Differential Revision: D67354440
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 18, 2024
Summary: Delete the following API: - capture_pre_autograd_graph() - capture_pre_autograd_graph_using_training_ir() - gm_using_training_ir() Update XLA pin to include pytorch/xla#8398 There's no more call sites to `capture_pre_autograd_graph`. Except 1) two test cases in coreml, guarded by version guard, PR to remove: apple/coremltools#2400 2) a few call sites guarded by version guard (< 2.5.0) Test Plan: CI Differential Revision: D67354440 Pull Request resolved: #143426 Approved by: https://github.com/gmagogsfm
aditew01
pushed a commit
to aditew01/pytorch
that referenced
this pull request
Dec 18, 2024
Summary: Delete the following API: - capture_pre_autograd_graph() - capture_pre_autograd_graph_using_training_ir() - gm_using_training_ir() There's no more call sites to `capture_pre_autograd_graph`. Except 1) two test cases in coreml, PR to remove: apple/coremltools#2400 2) XLA: one test case in pytorch/xla, PR to remove: pytorch/xla#8398 3) a few call sites guarded by version guard (< 2.5.0) Test Plan: CI Reviewed By: tugsbayasgalan Differential Revision: D64056353 Pull Request resolved: pytorch#143224 Approved by: https://github.com/tugsbayasgalan
aditew01
pushed a commit
to aditew01/pytorch
that referenced
this pull request
Dec 18, 2024
Summary: Delete the following API: - capture_pre_autograd_graph() - capture_pre_autograd_graph_using_training_ir() - gm_using_training_ir() Update XLA pin to include pytorch/xla#8398 There's no more call sites to `capture_pre_autograd_graph`. Except 1) two test cases in coreml, guarded by version guard, PR to remove: apple/coremltools#2400 2) a few call sites guarded by version guard (< 2.5.0) Test Plan: CI Differential Revision: D67354440 Pull Request resolved: pytorch#143426 Approved by: https://github.com/gmagogsfm
qihqi
pushed a commit
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capture_pre_autograd_graph API is deprecated and will be deleted.