Correct the cxx11_abi condition #8357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cxx11_abi is a number variable that is either 0 or 1. Unfortunately, when specifying it in the `when:` ansible stanza, a numeric value of 0 may get interpreted as true. This causes our nightly wheels from Oct 28 to Nov 04 to be renamed with a "cxx11" suffix, regardless if they actually used C++11 ABI.
tengyifei
requested review from
will-cromar,
JackCaoG,
lsy323,
ManfeiBai and
zpcore
as code owners
|
c.f. older PR that introduced C++11 ABI builds: https://github.com/pytorch/xla/pull/8307/files |
|
@tengyifei for 2.6 release:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cxx11_abi is a
stringvariable that is either "0" or "1". Unfortunately, when specifying it in thewhen:ansible stanza, a string value of "0" may get interpreted as true. This causes our nightly wheels from Oct 28 to Nov 04 to be renamed with a "cxx11" suffix, regardless if they actually used C++11 ABI.