Add VSCode devcontainer instructions to CONTRIBUTING.md #7072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
reviewed
May 17, 2024
| @@ -42,10 +87,6 @@ We recommend you to use our prebuilt Docker image to start your development work | |||
| python setup.py develop | |||
| ``` | |||
|
|
|||
| ### Build PyTorch/XLA from source with GPU support | |||
|
|
|||
| Please refer to this [guide](https://github.com/pytorch/xla/blob/master/docs/gpu.md#develop-pytorchxla-on-a-gpu-instance-build-pytorchxla-from-source-with-gpu-support). | |||
There was a problem hiding this comment.
this is actually useful, user has to run
echo "export PATH=\$PATH:/usr/local/cuda-12.1/bin" >> ~/.bashrc
echo "export LD_LIBRARY_PATH=\$LD_LIBRARY_PATH:/usr/local/cuda-12.1/lib64" >> ~/.bashrc
source ~/.bashrc
to build on GPU docker.
There was a problem hiding this comment.
I've needed to do that before inside containers in GKE (which uses a different container runtime), but never with Docker with nvidia-container-toolkit installed. Are you sure that's still necessary?
There was a problem hiding this comment.
Last time I tried(~1 month ago) I still need it with the GPU docker.
There was a problem hiding this comment.
Got it. I'll revert this change for now and give it an update next time I break my GPU build machine
JackCaoG
approved these changes
May 17, 2024
|
I also added some small fixes to the common VSCode config:
|
zpcore
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested these instructions because I broke my build environment and had to start from scratch.
Remove extra GPU instructions because this should be handled by dev container.