add DDP with SPMD example #7063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonb377
approved these changes
May 15, 2024
| device_ids = np.arange(num_devices) | ||
| mesh_shape = (num_devices, 1, 1, 1) | ||
| # We know data is 4d and 0th dimension is the batch dimension | ||
| input_mesh = xs.Mesh(device_ids, mesh_shape, ('B', 'C', 'W', 'H')) |
There was a problem hiding this comment.
I think we should revisit the mesh shape for these examples - right now it's based on the input tensor shape, but in general we want to reuse the mesh across input and model parameters.
We could do something like MaxText or the shardings example, with data, fsdp, and tensor axes, and recombine them using the partition spec (in this case only with the data axis):
mesh_shape = (num_devices,)
mesh = xs.Mesh(device_ids, mesh_shape, ('data',))
# Shard the input's batch dimension along the `data` axis, no sharding along other dimensions
input_sharding=xs.ShardingSpec(mesh, ('data', None, None, None))There was a problem hiding this comment.
Great! Let me update the example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.