Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin update 20240513 #7052

Merged
merged 1 commit into from
May 14, 2024
Merged

Pin update 20240513 #7052

merged 1 commit into from
May 14, 2024

Conversation

qihqi
Copy link
Collaborator

@qihqi qihqi commented May 13, 2024

No description provided.

JackCaoG
JackCaoG approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all test passed

@JackCaoG JackCaoG added the tpuci label May 13, 2024
@JackCaoG
Copy link
Collaborator

Seems like some stablehlo test failed

@qihqi qihqi force-pushed the qihqi/pin_update branch from 92fc046 to c70817d Compare May 13, 2024 21:35
@qihqi
Copy link
Collaborator Author

qihqi commented May 13, 2024

Seems like some stablehlo test failed

Chatted with @lsy323 decided to disable it first to unblock pin update.

@lsy323 lsy323 self-requested a review May 13, 2024 22:39
ManfeiBai
ManfeiBai approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

alanwaketan
alanwaketan approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qihqi qihqi merged commit 2b28ae2 into master May 14, 2024
20 checks passed
@qihqi qihqi deleted the qihqi/pin_update branch May 14, 2024 17:17
@lsy323 lsy323 mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackCaoG JackCaoG JackCaoG approved these changes

@ManfeiBai ManfeiBai ManfeiBai approved these changes

@bhavya01 bhavya01 bhavya01 approved these changes

@alanwaketan alanwaketan alanwaketan approved these changes

@lsy323 lsy323 lsy323 approved these changes

@will-cromar will-cromar Awaiting requested review from will-cromar

Assignees
No one assigned
Labels
2024Q2-manfei-review tpuci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qihqi @JackCaoG @lsy323 @alanwaketan @bhavya01 @ManfeiBai